Skip to content

Added fq to ACORN query example #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added fq to ACORN query example #3847

wants to merge 1 commit into from

Conversation

@aruggero
Copy link
Contributor

@aruggero aruggero commented Nov 7, 2025

Description

Just a small improvement in the ACORN query example in the documentation.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 7, 2025
epugh
epugh approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Does there need to be any extra descriptive text about the parameter?

@aruggero
Copy link
Contributor Author

aruggero commented Nov 7, 2025

Lgtm. Does there need to be any extra descriptive text about the parameter?

Hi @epugh,
I don't think since just before we say:
"ACORN is an algorithm designed to make hybrid searches consisting of a filter and a vector search more efficient."
So it does make sense to use/set this only with a filter.

Do you agree?

@epugh
Copy link
Contributor

epugh commented Nov 7, 2025

Lgtm. Does there need to be any extra descriptive text about the parameter?

Hi @epugh, I don't think since just before we say: "ACORN is an algorithm designed to make hybrid searches consisting of a filter and a vector search more efficient." So it does make sense to use/set this only with a filter.

Do you agree?

Perfect. Reading on my phone was not the best way! Ping me if you want me to merge.

@aruggero
Copy link
Contributor Author

aruggero commented Nov 7, 2025

Lgtm. Does there need to be any extra descriptive text about the parameter?

Hi @epugh, I don't think since just before we say: "ACORN is an algorithm designed to make hybrid searches consisting of a filter and a vector search more efficient." So it does make sense to use/set this only with a filter.
Do you agree?

Perfect. Reading on my phone was not the best way! Ping me if you want me to merge.

Yes thank you @epugh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epugh epugh epugh approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aruggero @epugh